Skip to content

[fuzz]: fix oss fuzz 32643, Config validation of lb_subset_config for server fuzz test #16582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asraa merged 3 commits into from
May 21, 2021
Merged

[fuzz]: fix oss fuzz 32643, Config validation of lb_subset_config for server fuzz test #16582

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ba3a47
add config validate
May 19, 2021
3d3ad7b
format
May 19, 2021
0ba1d6a
add comment and minor refactor
May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions test/server/server_corpus/invalid_lb_subset_config
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 27 additions & 0 deletions test/server/server_fuzz_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,34 @@ makeHermeticPathsAndPorts(Fuzz::PerTestEnvironment& test_env,
return output;
}

// When single_host_per_subset is set to be true, only expect 1 subset selector and 1 key inside the
// selector.
bool validateLbSubsetConfig(const envoy::config::bootstrap::v3::Bootstrap& input) {
for (auto& cluster : input.static_resources().clusters()) {
bool use_single_host_per_subset = 0;
int subset_selectors = 0;
for (auto& subset_selector : cluster.lb_subset_config().subset_selectors()) {
subset_selectors++;
if (subset_selector.single_host_per_subset()) {
use_single_host_per_subset = true;
if (subset_selector.keys().size() != 1) {
return false;
}
}
}
if (use_single_host_per_subset && subset_selectors != 1) {
Comment thread
asraa marked this conversation as resolved.
Outdated
return false;
}
}
return true;
}

DEFINE_PROTO_FUZZER(const envoy::config::bootstrap::v3::Bootstrap& input) {

if (!validateLbSubsetConfig(input)) {
Comment thread
asraa marked this conversation as resolved.
return;
}

testing::NiceMock<MockOptions> options;
DefaultListenerHooks hooks;
testing::NiceMock<MockHotRestart> restart;
Expand Down