Skip to content

http: more tests for local reply and reset #16526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 2 commits into from
May 18, 2021
Merged

http: more tests for local reply and reset #16526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da7be9b
http: more tests for local reply and reset
alyssawilk May 17, 2021
57a6bfb
format
alyssawilk May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions test/integration/filters/on_local_reply_filter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,23 @@ class OnLocalReplyFilter : public Http::PassThroughFilter {
if (!request_headers.get(Http::LowerCaseString("reset")).empty()) {
reset_ = true;
}
decoder_callbacks_->sendLocalReply(Http::Code::BadRequest, "body", nullptr, absl::nullopt,
"details");
if (!request_headers.get(Http::LowerCaseString("dual-local-reply")).empty()) {
dual_reply_ = true;
}
decoder_callbacks_->sendLocalReply(Http::Code::BadRequest, "original_reply", nullptr,
absl::nullopt, "original_reply");
return Http::FilterHeadersStatus::StopIteration;
}

Http::FilterHeadersStatus encodeHeaders(Http::ResponseHeaderMap&, bool) override {
if (dual_reply_) {
decoder_callbacks_->sendLocalReply(Http::Code::BadRequest, "second_reply", nullptr,
absl::nullopt, "second_reply");
return Http::FilterHeadersStatus::StopIteration;
}
return Http::FilterHeadersStatus::Continue;
}

Http::LocalErrorStatus onLocalReply(const LocalReplyData&) override {
if (reset_) {
return Http::LocalErrorStatus::ContinueAndResetStream;
Expand All @@ -29,6 +41,7 @@ class OnLocalReplyFilter : public Http::PassThroughFilter {
}

bool reset_{};
bool dual_reply_{};
};

class OnLocalReplyFilterConfig : public Extensions::HttpFilters::Common::EmptyHttpFilterConfig {
Expand Down
16 changes: 16 additions & 0 deletions test/integration/multiplexed_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1781,11 +1781,27 @@ TEST_P(Http2IntegrationTest, OnLocalReply) {
initialize();

codec_client_ = makeHttpConnection(lookupPort("http"));
// The filter will send a local reply when receiving headers, the client
// should get a complete response.
{
auto response = codec_client_->makeHeaderOnlyRequest(default_request_headers_);
ASSERT_TRUE(response->waitForEndStream());
ASSERT_TRUE(response->complete());
EXPECT_EQ("original_reply", response->body());
}
// The filter will send a local reply when receiving headers, and interrupt
// that with a second reply sent from the encoder chain. The client will see
// the second response.
{
default_request_headers_.addCopy("dual-local-reply", "yes");
auto response = codec_client_->makeHeaderOnlyRequest(default_request_headers_);
ASSERT_TRUE(response->waitForEndStream());
ASSERT_TRUE(response->complete());
EXPECT_EQ("second_reply", response->body());
}
// The filter will send a local reply when receiving headers and reset the
// stream onLocalReply. The client will get a reset and no response even if
// dual local replies are on (from the prior request).
{
default_request_headers_.addCopy("reset", "yes");
auto response = codec_client_->makeHeaderOnlyRequest(default_request_headers_);
Expand Down