Merged
Conversation
|
Hi @luckyxiaoqiang, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Member
|
@luckyxiaoqiang could you fix DCO please - change looks good |
luckyxiaoqiang
force-pushed
the
fix_subtitle_format
branch
from
23e59e7 to
cab00c8
Compare
Signed-off-by: luckyxiaoqiang <xiaoqiangding@126.com>
luckyxiaoqiang
force-pushed
the
fix_subtitle_format
branch
from
cab00c8 to
6e209e4
Compare
Contributor
Author
Fixed. |
Member
|
/retest |
|
Retrying Azure Pipelines: |
Member
|
aargghhh /retest |
|
Retrying Azure Pipelines: |
ntgsx92
pushed a commit
to ntgsx92/envoy
that referenced
this pull request
May 18, 2021
Signed-off-by: luckyxiaoqiang <xiaoqiangding@126.com> Signed-off-by: Sixiang Gu <sgu@twitter.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: luckyxiaoqiang <xiaoqiangding@126.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: luckyxiaoqiang xiaoqiangding@126.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: docs: Fix subtitle format
Additional Description: Fix format of subtitle in
original_dst_filter.rst. To view the old wrong format we can view this page . SubtitleLinuxandWindowsshould be child ofOriginal Destination.Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]