router/jwt_authn: remove support for v2 deprecated regex and cors.#16517
Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom Jun 1, 2021
Merged
router/jwt_authn: remove support for v2 deprecated regex and cors.#16517alyssawilk merged 2 commits intoenvoyproxy:mainfrom
alyssawilk merged 2 commits intoenvoyproxy:mainfrom
Conversation
Risk level: Low Testing: Unit tests modified. Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
requested review from
asraa,
ggreenway,
lizan and
mattklein123
as code owners
Member
Author
|
/assign-from @envoyproxy/maintainers |
|
@envoyproxy/maintainers assignee is @mattklein123 |
Member
Author
|
/assign-from @envoyproxy/maintainers |
|
@envoyproxy/maintainers assignee is @junr03 |
alyssawilk
previously approved these changes
May 20, 2021
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
YAY!!!!
LGTM modulo that one question
| header_match_type_ = HeaderMatchType::Value; | ||
| value_ = config.exact_match(); | ||
| break; | ||
| case envoy::config::route::v3::HeaderMatcher::HeaderMatchSpecifierCase:: |
Contributor
There was a problem hiding this comment.
I don't love that there's a default in this switch statement. lazy check: we'll fail to load before we can hit tihs case yeah?
Contributor
There was a problem hiding this comment.
We could add LOG_EVERY_N error when the default is hit.
Member
Author
There was a problem hiding this comment.
This is intentional behavior it seems, see
Contributor
|
oh, and needs merge :-/ |
Contributor
|
/wait |
Member
Author
|
Conflict fixed, PTAL and please merge if looks good as I'm OOO. Thanks. |
Contributor
|
cc @phlax just to make sure this one was on your radar |
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…nvoyproxy#16517) Risk level: Low Testing: Unit tests modified. Signed-off-by: Harvey Tuch <htuch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk level: Low
Testing: Unit tests modified.
Signed-off-by: Harvey Tuch htuch@google.com