thrift: add req/resp size histograms#16508
Merged
zuercher merged 18 commits intoenvoyproxy:mainfrom May 24, 2021
Merged
Conversation
Before adding tests/docs/changelog entry, I have a design question:
How do we feel about reusing the existing `upstream_{rq,rs}_body_size`
stats for clusters? They are originally aimed at HTTP, but I think
it's probably fine to reuse them for Thrift (and maybe even some
other protos, in the future).
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
cc: @zuercher @fishcakez @williamsfu99 for the design question. |
Member
Author
|
Related to #15908. |
added 3 commits
May 15, 2021 09:40
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
…t-response-histograms
Member
Author
|
For consistency with #15884, I'll add new |
Make things match with what envoyproxy#15884 does. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
/wait Will update tests in a bit. |
added 2 commits
May 17, 2021 19:13
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
…t-response-histograms
rgs1
changed the title
…t-response-histograms
source/extensions/filters/network/thrift_proxy/router/router_impl.cc
Outdated
Show resolved
Hide resolved
added 5 commits
May 18, 2021 13:29
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
…t-response-histograms
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
…t-response-histograms
…t-response-histograms
zuercher
reviewed
May 19, 2021
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
Generally looks good. I have some comments below. Also, when you're ready for another review, would you mind updating the PR description with the fields from the PR template?
docs/root/configuration/other_protocols/thrift_filters/router_filter.rst
Outdated
Show resolved
Hide resolved
source/extensions/filters/network/thrift_proxy/router/router_impl.cc
Outdated
Show resolved
Hide resolved
source/extensions/filters/network/thrift_proxy/router/router_impl.cc
Outdated
Show resolved
Hide resolved
added 4 commits
May 19, 2021 19:21
…t-response-histograms
…t-response-histograms
…t-response-histograms
zuercher
reviewed
May 21, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
These new histograms should be useful for tracking large requests and responses in deployments using the Thrift Proxy. This is a follow-up to envoyproxy#15884. Risk Level: low Testing: tests added & updated. Docs Changes: yes, the new histograms and the details of their behavior has been documented. Release Notes: added. Platform Specific Features: n/a Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
This is a follow-up to #15884.
Additional Description: These new histograms should be useful for tracking large requests and responses
in deployments using the Thrift Proxy.
Risk Level: low
Testing: tests added & updated.
Docs Changes: yes, the new histograms and the details of their behavior has been documented.
Release Notes: added.
Platform Specific Features: this is entirely x-platform.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com