Skip to content

Update ConfigDump documentation. #16491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoniovicente merged 4 commits into from
May 20, 2021
Merged

Update ConfigDump documentation. #16491

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27ce320
Update ConfigDump documentation.
paul-r-gall May 13, 2021
b752456
run proto_format.sh
paul-r-gall May 18, 2021
4eed99d
Merge remote-tracking branch 'upstream/main' into ConfigDumpDocFix
paul-r-gall May 18, 2021
0091012
Merge remote-tracking branch 'upstream/main' into ConfigDumpDocFix
paul-r-gall May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/envoy/admin/v3/config_dump.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ message ConfigDump {
// * *clusters*: :ref:`ClustersConfigDump <envoy_v3_api_msg_admin.v3.ClustersConfigDump>`
// * *endpoints*: :ref:`EndpointsConfigDump <envoy_v3_api_msg_admin.v3.EndpointsConfigDump>`
// * *listeners*: :ref:`ListenersConfigDump <envoy_v3_api_msg_admin.v3.ListenersConfigDump>`
// * *scoped_routes*: :ref:`ScopedRoutesConfigDump <envoy_v3_api_msg_admin.v3.ScopedRoutesConfigDump>`
// * *routes*: :ref:`RoutesConfigDump <envoy_v3_api_msg_admin.v3.RoutesConfigDump>`
// * *secrets*: :ref:`SecretsConfigDump <envoy_v3_api_msg_admin.v3.SecretsConfigDump>`

@antoniovicente antoniovicente May 14, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to know what PRs added support for these additional types?

@paul-r-gall paul-r-gall May 14, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

History search indicates that ScopedRouteConfigDump was added in #6932, and SecretsConfigDump was added in #7365.

//
// EDS Configuration will only be dumped by using parameter `?include_eds`
//
Expand Down