test: Removing orphan type_util_test file#16464
Merged
lizan merged 1 commit intoenvoyproxy:mainfrom May 12, 2021
Merged
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Contributor
Author
|
/assign @chaoqin-li1123 |
Contributor
|
Thanks! LGTM |
Contributor
|
I see, type_util.h and type_util.h are already removed. This test doesn't compile at all, should be safe to remove. |
antoniovicente
approved these changes
May 12, 2021
lizan
approved these changes
May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Removing orphan type_util_test file
Additional Description:
PR #16372 removed
source/common/protobuf/type_util.h, but its test file,test/common/protobuf/type_util_test.cc, wasn't removed.The contents of the test were moved to
test/common/protobuf/utility_test.cc, so removing the old test file should be ok.Risk Level: Low - removing unneeded test file.
Testing: Same tests already covered.
Docs Changes: N/A.
Release Notes: N/A/
Platform Specific Features: N/A.
Signed-off-by: Adi Suissa-Peleg adip@google.com