Skip to content

wasm: fix V8 build with --config={docker,remote}-msan. #16452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizan merged 1 commit into from
May 12, 2021
Merged

wasm: fix V8 build with --config={docker,remote}-msan. #16452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion bazel/external/wee8.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# 1. Fix linking with unbundled toolchain on macOS.
# 2. Increase VSZ limit to 64 TiB (allows us to start up to 6,553 VMs).
# 3. Fix MSAN linking.
# 3. Fix building and linking with MSAN.
--- wee8/build/toolchain/gcc_toolchain.gni
+++ wee8/build/toolchain/gcc_toolchain.gni
@@ -348,6 +348,8 @@ template("gcc_toolchain") {
Expand Down Expand Up @@ -53,3 +53,17 @@

if (use_libfuzzer && (is_linux || is_chromeos)) {
if (is_asan) {
--- wee8/build/config/compiler/BUILD.gn
+++ wee8/build/config/compiler/BUILD.gn
@@ -736,11 +736,6 @@ config("compiler") {
cflags += [ "-fcomplete-member-pointers" ]
}

- # TODO(crbug/1185183): Remove after next clang roll
- if (is_clang && !is_nacl && is_linux && is_msan) {
- cflags += [ "-flegacy-pass-manager" ]
- }
-
# Pass the same C/C++ flags to the objective C/C++ compiler.
cflags_objc += cflags_c
cflags_objcc += cflags_cc