test: deflake upstream starttls integration test#16436
Merged
antoniovicente merged 13 commits intoenvoyproxy:mainfrom May 14, 2021
Merged
test: deflake upstream starttls integration test#16436antoniovicente merged 13 commits intoenvoyproxy:mainfrom
antoniovicente merged 13 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
@bryce-anderson PTAL. linux_x64 gcc fails because of the known issue (params list is too long). |
Contributor
Do you have info on failure rates before / after this change? Looking at the changes now. |
Contributor
Author
|
@antoniovicente |
antoniovicente
approved these changes
May 14, 2021
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
This change seems like a massive improvement to the existing test. Many thanks for doing this.
Contributor
|
Could you merge upstream/main to pickup the mitigation for the gcc CI failure? /wait |
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Contributor
Author
|
CI is happy now after merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
de-flake upstream starttls integration test.
Additional Description:
Risk Level: Low
Testing: unit and integration
Docs Changes: No
Release Notes: No
Platform Specific Features: No
Fixes #16365