Skip to content

Fix bug in flaky test script #16434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoniovicente merged 6 commits into from
May 17, 2021
Merged

Fix bug in flaky test script #16434

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e3fbaf7
fix bug in flaky test script
May 11, 2021
e1666df
remove caching
May 11, 2021
9cab35f
kick ci
May 11, 2021
df715f0
update the script given that '.' always exists
May 12, 2021
774943c
kick ci again
May 12, 2021
fbf5f2b
remove the no caching option
May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ci/flaky_test/process_xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,17 @@ def parse_and_print_test_suite_error(testsuite, log_path):
# finding the last test case to run. The expected format of that is:
# "[ RUN ] <TestParams>/<TestSuite>.<TestCase>\n".
last_test_fullname = test_output.split('[ RUN ]')[-1].splitlines()[0]
last_testsuite = last_test_fullname.split('/')[1].split('.')[0]
last_testcase = last_test_fullname.split('.')[1]
last_test_fullname_splitted_on_slash = last_test_fullname.split('/')
Comment thread
davinci26 marked this conversation as resolved.
Outdated
if len(last_test_fullname_splitted_on_slash) == 2:
last_testsuite = last_test_fullname_splitted_on_slash[1].split('.')[0]
else:
last_testsuite = "Could not retrieve last test suite"

last_test_fullname_splitted_on_dot = last_test_fullname.split('.')
if len(last_test_fullname_splitted_on_dot) == 2:
last_testcase = last_test_fullname_splitted_on_dot[1]
else:
last_testcase = "Could not retrieve last test case"

if error_msg != "":
return print_test_suite_error(
Expand Down
3 changes: 2 additions & 1 deletion ci/windows_ci_steps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@ fi
# Environment setup.
export TEST_TMPDIR=${BUILD_DIR}/tmp

[[ "${BUILD_REASON}" != "PullRequest" ]] && BAZEL_EXTRA_TEST_OPTIONS+=(--nocache_test_results)
#[[ "${BUILD_REASON}" != "PullRequest" ]] && BAZEL_EXTRA_TEST_OPTIONS+=(--nocache_test_results)
Comment thread
davinci26 marked this conversation as resolved.
Outdated

BAZEL_EXTRA_TEST_OPTIONS+=(--nocache_test_results)
BAZEL_STARTUP_OPTIONS+=("--output_base=${TEST_TMPDIR/\/c/c:}")
BAZEL_BUILD_OPTIONS=(
-c opt
Expand Down