Document that python3-pip is a build dependency.

[jpeach]

Commit Message:

The python3-pip package is needed on both Ubuntu and Fedora.

Additional Description:
Risk Level: Low
Testing: None
Docs Changes: Y
Release Notes: N
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

[phlax]

currently this is correct - pip is required - but worth mentioning that im gradually shifting things to bazel - once that is complete pip will be optional

[phlax]

we should probably also add jq as that has been added into the build environment also

[jpeach]

we should probably also add jq as that has been added into the build environment also

I see it used in docs/build.sh, but is it actually used for builds via bazel? Experimentally, bazel build //source/exe:envoy-static succeeds for me and I happen to not have jq installed.

I'm also happy to update the dependency list from a canonical source of truth if there is one.

[phlax]

I see it used in docs/build.sh, but is it actually used for builds via bazel?

the docs build tasks are all being moved to bazel more generally - the task that uses jq (currentlly) is about to be moved to bazel specifically

Experimentally, bazel build //source/exe:envoy-static succeeds for me and I happen to not have jq installed.

yep - only the docs build currently

the point about adding more tools here is so that it ~matches what is in the containers created in envoy-build-tools - ie https://github.com/envoyproxy/envoy-build-tools/blob/2d4bdba38113cd9bf758c2609f40ce90014e52af/build_container/build_container_ubuntu.sh#L50 as those are the packages that are expected to be in the system environmentt and available to bazel tasks

[jpeach]

I see it used in docs/build.sh, but is it actually used for builds via bazel?

the docs build tasks are all being moved to bazel more generally - the task that uses jq (currentlly) is about to be moved to bazel specifically

Experimentally, bazel build //source/exe:envoy-static succeeds for me and I happen to not have jq installed.

yep - only the docs build currently

the point about adding more tools here is so that it ~matches what is in the containers created in envoy-build-tools - ie https://github.com/envoyproxy/envoy-build-tools/blob/2d4bdba38113cd9bf758c2609f40ce90014e52af/build_container/build_container_ubuntu.sh#L50 as those are the packages that are expected to be in the system environmentt and available to bazel tasks

Hm, maybe that list isn't the best choice; looks overly broad to me. Is it really necessary to have 2 versions of python, graphviz, docker, tshark and google-cloud-sdk to build envoy?

[phlax]

Is it really necessary to have 2 versions of python, graphviz, docker, tshark and google-cloud-sdk to build envoy?

imho that image is a bit of a mess - i never use it - its huge and the permissions are fu

but that is the ~authoritative list of what is required from an env to run ci - most of which is bazel, or being moved to it

im happy with just adding jq - but im also happy to add it after if needs be

[jpeach]

im happy with just adding jq - but im also happy to add it after if needs be

OK, I'd prefer to add it later when it's truly needed (the bazel port could end up using native starlark rather than shelling to jq)

[phlax]

the bazel port could end up using native starlark rather than shelling to jq

thats unlikely, we just added jq specifically for this purpose

[phlax]

lgtm, thanks