Update rules_apple#16404
Merged
lizan merged 1 commit intoenvoyproxy:mainfrom May 12, 2021
vladmos:update_rules_apple
Merged
Conversation
repokitteh-read-only
bot
added
the
deps
Signed-off-by: Vladimir Moskva <vladmos@google.com>
Contributor
Author
|
"envoy-presubmit (precheck dependencies)" is failing because GitHub returned 502, how do I rerun the tests? |
moderation
reviewed
May 10, 2021
| sha256 = "c84962b64d9ae4472adfb01ec2cf1aa73cb2ee8308242add55fa7cc38602d882", | ||
| urls = ["https://github.com/bazelbuild/rules_apple/releases/download/{version}/rules_apple.{version}.tar.gz"], | ||
| release_date = "2019-10-10", | ||
| release_date = "2021-05-04", |
Contributor
There was a problem hiding this comment.
The UTC for this release is 2021-05-07 however it's possible that the last commit for the release is 2021-05-04
Contributor
Author
There was a problem hiding this comment.
I initially submitted it with "2021-05-07" but a test failed saying that it should have been "2021-05-04".
Contributor
There was a problem hiding this comment.
No problem. I'll fix-up when I update the release date check.
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
|
Retrying Azure Pipelines: |
lizan
approved these changes
May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: build: update rules_apple to the latest version
Additional Description: The current version of rules_apple is not compatible with future versions of Bazel and will cause breakages
Risk Level: Low
Testing: CI
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A