matching: disable hcm integration by default#16387
Merged
snowp merged 13 commits intoenvoyproxy:mainfrom May 12, 2021
Merged
Conversation
added 6 commits
May 7, 2021 22:55
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Looks good, just needs a spelling fix.
| } | ||
| }; | ||
|
|
||
| TEST(MatchWrapper, DisbaledByDefault) { |
added 2 commits
May 8, 2021 00:04
added 4 commits
May 10, 2021 15:07
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Contributor
Author
|
@antoniovicente LMK if you're okay with this, I took a look at what it would look like to remove the examples but it requires leaving empty docs pages around to avoid dangling references in protos/release notes so not sure if it's worth it. |
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Contributor
Author
|
Marking for backport to 1.8.x (cc @dmitri-d) |
htuch
pushed a commit
that referenced
this pull request
May 21, 2021
Contributor
|
checking back in as we cut the release, what's the plan with this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As this is an experimental feature, hide it behind a false by default runtime guard to prevent usage without being
aware of this.
A match tree can still be instantiated via internal APIs, but this should disable the primary way
of enabling this via configuration by default.
Signed-off-by: Snow Pettersen snowp@lyft.com
Risk Level: Low
Testing: UTs
Docs Changes: n/a
Release Notes: Release note added