Skip to content

docs: record distroless images#16359

Merged
phlax merged 4 commits intoenvoyproxy:mainfrom
daixiang0:docker-doc
May 10, 2021
Merged

docs: record distroless images#16359
phlax merged 4 commits intoenvoyproxy:mainfrom
daixiang0:docker-doc

Conversation

@daixiang0
Copy link
Copy Markdown
Member

@daixiang0 daixiang0 commented May 6, 2021

Signed-off-by: Long Dai long0dai@foxmail.com

Commit Message:

Document addition of distroless Docker image:

  • add to table of available docker images
  • add in getting started > install > docker (in a separate tab - Envoy (distroless))

Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Partial fix for #16282

Signed-off-by: Long Dai <long0dai@foxmail.com>
@repokitteh-read-only
Copy link
Copy Markdown

Hi @daixiang0, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #16359 was opened by daixiang0.

see: more, trace.

@phlax phlax self-assigned this May 6, 2021
@phlax
Copy link
Copy Markdown
Member

phlax commented May 6, 2021

Signed-off-by: Long Dai <long0dai@foxmail.com>
@daixiang0
Copy link
Copy Markdown
Member Author

ping @phlax

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @daixiang0 looking good

the image table needs some further work

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops approved and didnt add change request...

Signed-off-by: Long Dai <long0dai@foxmail.com>
Signed-off-by: Long Dai <long0dai@foxmail.com>
@phlax
Copy link
Copy Markdown
Member

phlax commented May 7, 2021

@daixiang0 looks good

while testing out the docs i realised that there are some other problems that need to be fixed first - the existing instructions dont work correcctly - and this makes it worse

ill create a PR to fix docs shortly...

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daixiang0 i created 2 prs to address issues uncovered while testing your PR

one was an ongoing issue in relation to the docker docs #16380 and the other related to the distroless image in particular #16383

im happy for this to land in the meantime

@daixiang0
Copy link
Copy Markdown
Member Author

Thanks a lot!

@phlax phlax merged commit 9375301 into envoyproxy:main May 10, 2021
@daixiang0 daixiang0 deleted the docker-doc branch May 11, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants