Add a windows sample

[davinci26]

Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com

Fixes #13281

Risk Level: Low
Testing: Manual
Docs Changes: Added
Release Notes: N/A
Platform Specific Features: N/A

[davinci26]

@phlax I am adding this without verification first and I will follow up with an issue and a PR for the verification.

Also there is precedent with non verified examples wasm-cc is on the same boat.

[davinci26]

cc @envoyproxy/windows-dev

[davinci26]

@phlax the shellcheck is giving me a hard time with error but I am not sure why:

In ci/verify_examples.sh line 37:
    examples=$(find . -mindepth 1 -maxdepth 1 -type d -name "$TESTFILTER" ! -iname "_*"  $excluded_names | sort)
                                                                                         ^-- SC2086: Double quote to prevent globbing and word splitting.

Is there a bashy way to fix this?

[phlax]

Is there a bashy way to fix this?

not really if you mean autodiff (there is but it doesnt work well enough for even trivial use)

the error is pretty self-explanatory - add " around vars to prevent them unexpectedly splitting

[davinci26]

@phlax well the suggestion is wrong though. Adding "" makes the command to fail. Which is reasonable because I am intentionally splitting with multiple arguments in one string

[davinci26]

@sunjayBhatia since you have a lot of operating experience, do you mind doing a review

[wrowe]

This LGTM - very straightforward to follow. From an implementers' perspective @sunjayBhatia it would be good to get your thoughts before I proceed to merge. @phlax I trust your concerns are all addressed.

[phlax]

can we please warn users that the image is large and not open source

[pravb]

@phlax for developers who are using or interested in Windows they already know that it is not open source so IMO no specific warning is needed. Envoy and Envoy Mobile is also supported on multiple other platforms that are based on non-open source software. We can certainly list the approximate image size in case the user is on a bandwidth constrained network.

[sunjayBhatia]

looks good, just some small nits

[davinci26]

@wrowe / @phlax any more outstanding comments?

[wrowe]

LGTM

Week has passed since review was re-requested, per discussion the remaining question appear moot, and could be addressed in that PR as needed