listener: no io_handle for virtual listener#16259
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
/retest |
|
Retrying Azure Pipelines: |
|
This seems to be an experimental PR, would you tag this is as draft till it's ready for review? |
I think the product code is ready since it doesn't break any. |
…y-dai into noiohandleinvirtuallistener
lambdai
changed the title
|
@wrowe This PR is ready to review. Could you take a look? Thanks! |
wrowe
left a comment
wrowe
left a comment
There was a problem hiding this comment.
This looks correct to me, thanks!
|
Can you update the description to correspond to the final commit message you want, @lambdai, it still reads like a draft. |
Updated. Thanks! |
lambdai
changed the title
|
Thank you! |
The io handle for tcp listener is to drive the accepted connection by event poller. If the tcp listener doesn't bind to port, the io handle is not required. Signed-off-by: Yuchen Dai <silentdai@gmail.com>
2 participants
The io handle for tcp listener is to drive the accepted connection by event poller.
If the tcp listener doesn't bind to port, the io handle is not required.
Signed-off-by: Yuchen Dai silentdai@gmail.com
Commit Message:
Additional Description:
Risk Level: LOW
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
fix #16258
[Optional Deprecated:]
[Optional API Considerations:]