Skip to content

tcp listener: log source IP#16148

Merged
yanavlasov merged 13 commits intoenvoyproxy:mainfrom
rgs1:active-tcp-listener-logging
Jun 3, 2021
Merged

tcp listener: log source IP#16148
yanavlasov merged 13 commits intoenvoyproxy:mainfrom
rgs1:active-tcp-listener-logging

Conversation

@rgs1
Copy link
Copy Markdown
Member

@rgs1 rgs1 commented Apr 23, 2021

Useful while debugging TLS (and general) connection issues.

Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com

Raul Gutierrez Segales added 2 commits April 23, 2021 15:03
Useful while debugging TLS (and general) connection issues.

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Fix
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
@rgs1
Copy link
Copy Markdown
Member Author

rgs1 commented Apr 23, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16148 (comment) was created by @rgs1.

see: more, trace.

lambdai
lambdai previously approved these changes Apr 26, 2021
Copy link
Copy Markdown
Contributor

@lambdai lambdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Since the goal is debugging, you may want to add the source ip to
ENVOY_LOG(debug, "closing connection: no matching filter chain found");
and
ENVOY_CONN_LOG(debug, "closing connection: no filters", *active_connection->connection_);

It's up to you.

Raul Gutierrez Segales added 2 commits April 27, 2021 10:47
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Raul Gutierrez Segales added 4 commits April 28, 2021 13:00
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Fix
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Copy link
Copy Markdown
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @yanavlasov do you want to do a final pass as well?

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 29, 2021
@zuercher zuercher removed the stale stalebot believes this issue/PR has not been touched recently label Jun 2, 2021
@yanavlasov yanavlasov merged commit 4f0882b into envoyproxy:main Jun 3, 2021
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Useful while debugging TLS (and general) connection issues.

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants