-
Notifications
You must be signed in to change notification settings - Fork 5.5k
tracing: general tracing support #16049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
d78258e
520cdc9
43cc47e
8740d85
38a2e80
53d0c58
b259a2a
bde8346
f7d9ce9
dc57c3c
38aba26
e8427f0
f535c8e
5f0c81a
d4d6910
6341150
1c5d1e0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package envoy.config.trace.v3; | ||
|
|
||
| import "google/protobuf/any.proto"; | ||
|
|
||
| import "udpa/annotations/status.proto"; | ||
| import "udpa/annotations/versioning.proto"; | ||
| import "validate/validate.proto"; | ||
|
|
||
| option java_package = "io.envoyproxy.envoy.config.trace.v3"; | ||
| option java_outer_classname = "TracerProto"; | ||
| option java_multiple_files = true; | ||
| option (udpa.annotations.file_status).package_version_status = ACTIVE; | ||
|
|
||
| // [#protodoc-title: Tracing] | ||
| // Tracing :ref:`architecture overview <arch_overview_tracing>`. | ||
|
|
||
| // The tracing configuration specifies settings for an tracer provider used by Envoy. | ||
| message TracerProvider { | ||
| // The name of the trace driver to instantiate. The name must match a supported trace driver. | ||
| // See the :ref:`extensions listed in typed_config below <extension_category_envoy.tracers>` for the | ||
| // default list of the trace driver. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In other places I see "tracing driver", "tracer driver" in addition to "trace driver" used interchangeably. Can we stick to a single term?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| string name = 1 [(validate.rules).string = {min_len: 1}]; | ||
|
|
||
| // Trace driver specific configuration which must be set according to the driver being instantiated. | ||
| // [#extension-category: envoy.tracers] | ||
| google.protobuf.Any typed_config = 2; | ||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where this is used?
And the content of this message is exactly same as
TypedExtensionConfigso we can just use that.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's designed to replace
envoy.config.trace.v3.Tracing.Httpin the future. There is no place to use it yet. But you are right, we can useTypedExtensionConfigdirectly. I will remove it.