-
Notifications
You must be signed in to change notification settings - Fork 5.5k
docs: unhiding HTTP/3 and adding docs #15926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 21 commits
4f190b3
bb5e934
28a6ea6
f20546f
5257f2f
0bad720
8ccb35a
1702e4c
7c9c5fa
f4ccb1d
d388cb9
4ec4357
a95b39c
e4151ae
76f04d6
c2496a3
62d053a
e10ad5f
58aa631
d2ad3ab
aa1f4ef
4fa9c31
323f151
56e08a6
bdb245f
752afc7
e2ee7a9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,8 +33,18 @@ message UdpListenerConfig { | |
|
|
||
| // Configuration for QUIC protocol. If empty, QUIC will not be enabled on this listener. Set | ||
| // to the default object to enable QUIC without modifying any additional options. | ||
| // [#not-implemented-hide:] | ||
| // [#comment:Unhide when QUIC alpha is announced with other docs.] | ||
| // | ||
| // .. note:: | ||
| // QUIC support is currently alpha and should be used with caution. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. im wondering if this note should be a warning - and also thinking it might be better placed in docs/root/intro/arch_overview/http/http3.rst as its linked to from various places - feels a bit arbitrary to add it to one proto
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I lean towards the API because I think folks will actually read it here, where I'm less confident of folks reading the docs. Happy to make it a warning through.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. im wondering if this should make use of the agreed that there needs to be a warning here - but i would put the fuller explanation in the ref docs and point to that - as is done in most of the the api protos - mho |
||
| // | ||
| // For known outstanding issues before Envoy QUIC support is GA, issues | ||
| // are tracked `here <https://github.com/envoyproxy/envoy/labels/quic-mvp>`_. | ||
| // For example QUIC does not currently support in-place filter chain updates, so users | ||
| // requiring dynamic config reload for QUIC should wait until | ||
| // `#13115 <https://github.com/envoyproxy/envoy/issues/13115>`_ has been addressed. | ||
| // | ||
| // For general feature requests beyond production readiness, you can track | ||
| // the `area-quic <https://github.com/envoyproxy/envoy/labels/area%2Fquic>`_ tag. | ||
| QuicProtocolOptions quic_options = 7; | ||
| } | ||
|
|
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ gRPC HTTP/1.1 reverse bridge | |
| * This filter should be configured with the name *envoy.filters.http.grpc_http1_reverse_bridge*. | ||
|
|
||
| This is a filter that enables converting an incoming gRPC request into a HTTP/1.1 request to allow | ||
| a server that does not understand HTTP/2 or gRPC semantics to handle the request. | ||
| a server that does not understand HTTP/2 or HTTP/3 or gRPC semantics to handle the request. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Totally your call... I wonder if we should be consistent about saying either "HTTP/2 or HTTP/3" vs "HTTP/2 or above". Probably not worth doing?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel like in some situations it's awkward to phrase it the other way :-/ |
||
|
|
||
| The filter works by: | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -140,9 +140,14 @@ upstream.healthy_panic_threshold | |
| Defaults to 50%. | ||
|
|
||
| upstream.use_http2 | ||
| Whether the cluster utilizes the *http2* if configured in `HttpProtocolOptions <envoy_v3_msg_config.upstreams.http.v3.HttpProtocolOptions>`. | ||
| Whether the cluster uses *http2* if configured in `HttpProtocolOptions <envoy_v3_msg_config.upstreams.http.v3.HttpProtocolOptions>`. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this one also i think should be double-backtick |
||
| Set to 0 to disable HTTP/2 even if the feature is configured. Defaults to enabled. | ||
|
|
||
| upstream.use_http3 | ||
| Whether the cluster uses *http3* if configured in `HttpProtocolOptions <envoy_v3_msg_config.upstreams.http.v3.HttpProtocolOptions>`. | ||
|
phlax marked this conversation as resolved.
Outdated
|
||
| Set to 0 to disable HTTP/3 even if the feature is configured. Defaults to enabled. | ||
|
|
||
|
|
||
| .. _config_cluster_manager_cluster_runtime_zone_routing: | ||
|
|
||
| Zone aware load balancing | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.