[WIP] docs: Fix broken :refs: and other api issues#15766
[WIP] docs: Fix broken :refs: and other api issues#15766phlax wants to merge 1 commit intoenvoyproxy:mainfrom
:refs: and other api issues#15766Conversation
:refs::refs: and unterminated comments
806c3aa to
6233f96
Compare
:refs: and unterminated comments:refs: and unterminated comments
:refs: and unterminated comments:refs: and other api issues
0757e2f to
f654f09
Compare
:refs: and other api issues:refs: and other api issues
tools/code_format/rst_check.py
Outdated
tools/code_format/rst_check.py
Outdated
There was a problem hiding this comment.
You have another WiP PR here; a bit confused..
There was a problem hiding this comment.
so the point was to move it there once that PR landed
i wanted to land this because it fixes actual problems, and then add a better solution in the follow up #15786
There was a problem hiding this comment.
Can you let me know when the Python is ready for final review?
tools/code_format/rst_check.py
Outdated
There was a problem hiding this comment.
Probably best to factor out the decode stuff for clarity.
tools/code_format/rst_check.py
Outdated
There was a problem hiding this comment.
Is the plan to expand this beyond just grep checking? If it's a grep wrapper, then a shell script is fine.
|
setting this to wip until other work has been done around tests/checks |
:refs: and other api issues:refs: and other api issues
Signed-off-by: Ryan Northey <ryan@synca.io>
|
closing this in favour of #15786 - the fixes here are already landed |
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: docs: Fix broken :refs: and other api issues
Additional Description:
adds a grep check for:
not-implemented-hide)...in the docs build and fixes the related issues
this can be updated to also include
rstcheckbut will require a bit more work (pr here for progress #15786 )Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #15710
[Optional Deprecated:]
[Optional API Considerations:]