Skip to content

[WIP] docs: Fix broken :refs: and other api issues#15766

Closed
phlax wants to merge 1 commit intoenvoyproxy:mainfrom
phlax:docs-fix-refs
Closed

[WIP] docs: Fix broken :refs: and other api issues#15766
phlax wants to merge 1 commit intoenvoyproxy:mainfrom
phlax:docs-fix-refs

Conversation

@phlax
Copy link
Member

@phlax phlax commented Mar 30, 2021

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: docs: Fix broken :refs: and other api issues
Additional Description:

adds a grep check for:

  • broken refs
  • incorrectly rendered annotations (currently comments, and not-implemented-hide)

...in the docs build and fixes the related issues

this can be updated to also include rstcheck but will require a bit more work (pr here for progress #15786 )

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #15710
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
API shepherd assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #15766 was opened by phlax.

see: more, trace.

@phlax phlax changed the title docs: Fix broken :refs: [WIP] docs: Fix broken :refs: Mar 30, 2021
@phlax phlax marked this pull request as draft March 30, 2021 14:22
@phlax phlax changed the title [WIP] docs: Fix broken :refs: docs: Fix broken :refs: Mar 30, 2021
@phlax phlax marked this pull request as ready for review March 30, 2021 15:40
@phlax phlax changed the title docs: Fix broken :refs: docs: Fix broken :refs: Mar 31, 2021
@phlax phlax changed the title docs: Fix broken :refs: docs: Fix broken :refs: and unterminated comments Mar 31, 2021
@phlax phlax force-pushed the docs-fix-refs branch 4 times, most recently from 806c3aa to 6233f96 Compare March 31, 2021 14:19
@phlax phlax changed the title docs: Fix broken :refs: and unterminated comments [WIP] docs: Fix broken :refs: and unterminated comments Mar 31, 2021
@phlax phlax marked this pull request as draft March 31, 2021 16:10
@phlax phlax changed the title [WIP] docs: Fix broken :refs: and unterminated comments [WIP] docs: Fix broken :refs: and other api issues Mar 31, 2021
@phlax phlax force-pushed the docs-fix-refs branch 3 times, most recently from 0757e2f to f654f09 Compare March 31, 2021 17:51
@phlax phlax changed the title [WIP] docs: Fix broken :refs: and other api issues docs: Fix broken :refs: and other api issues Mar 31, 2021
@phlax phlax marked this pull request as ready for review March 31, 2021 19:00
@phlax phlax requested a review from htuch March 31, 2021 19:00
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add function signature

@mattklein123 mattklein123 self-assigned this Apr 2, 2021
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have another WiP PR here; a bit confused..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the point was to move it there once that PR landed

i wanted to land this because it fixes actual problems, and then add a better solution in the follow up #15786

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you let me know when the Python is ready for final review?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wait

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to factor out the decode stuff for clarity.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to expand this beyond just grep checking? If it's a grep wrapper, then a shell script is fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my plan is to rewrite it with the proper rstcheck (ie #15786 ) and using class like in #15802 so its kinda temporary to do it this way - but it fixes the immediate issue and introduces the generated rst checking

@phlax
Copy link
Member Author

phlax commented Apr 3, 2021

setting this to wip until other work has been done around tests/checks

@phlax phlax marked this pull request as draft April 3, 2021 12:18
@phlax phlax changed the title docs: Fix broken :refs: and other api issues [WIP] docs: Fix broken :refs: and other api issues Apr 3, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Member Author

phlax commented Apr 16, 2021

closing this in favour of #15786 - the fixes here are already landed

@phlax phlax closed this Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken refs in api docs

4 participants