access log: support formatter extensions from json_format#15646
Merged
snowp merged 17 commits intoenvoyproxy:mainfrom Mar 30, 2021
Merged
access log: support formatter extensions from json_format#15646snowp merged 17 commits intoenvoyproxy:mainfrom
snowp merged 17 commits intoenvoyproxy:mainfrom
Conversation
This was missed in envoyproxy#14512. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
|
@envoyproxy/first-pass-reviewers to take the first pass. |
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
dmitri-d
reviewed
Mar 24, 2021
added 4 commits
March 24, 2021 14:19
Convenient for other users of the class. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
…rs-support-json-format
* extend the existing test to use the extension in multiple parts of the JSON doc * add additional test for multiple extensions Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Contributor
|
lgtm, @rgs1, provided CI is happy. |
snowp
suggested changes
Mar 25, 2021
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Thanks! Just a few comments
added 6 commits
March 25, 2021 15:38
…rs-support-json-format
TODO(rgs1): please add a clang-tidy check that flags these Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
…rs-support-json-format
snowp
suggested changes
Mar 26, 2021
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Thanks this looks good, just the one comment about a comment
added 2 commits
March 29, 2021 14:55
…rs-support-json-format
This avoids the dangers around a dangling reference. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
@snowp ready for another pass -- PTAL. Thanks! |
added 2 commits
March 30, 2021 10:57
…rs-support-json-format
phlax
reviewed
Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed in #14512.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com