Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/filter_example_setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
set -e

# This is the hash on https://github.com/envoyproxy/envoy-filter-example.git we pin to.
ENVOY_FILTER_EXAMPLE_GITSHA="30e5df3b73aec14ca3b70e4537e0b42f2e9d7fd0"
ENVOY_FILTER_EXAMPLE_GITSHA="8f0f8bba38868e875613b74f57df38f543e764ba"
ENVOY_FILTER_EXAMPLE_SRCDIR="${BUILD_DIR}/envoy-filter-example"

# shellcheck disable=SC2034
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class AdmissionControlIntegrationTest : public Event::TestUsingSimulatedTime,
public HttpIntegrationTest {
public:
AdmissionControlIntegrationTest()
: HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam(), realTime()) {}
: HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam()) {}

void SetUp() override {}

Expand Down
8 changes: 0 additions & 8 deletions test/integration/base_integration_test.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,27 +43,19 @@ struct ApiFilesystemConfig {
*/
class BaseIntegrationTest : protected Logger::Loggable<Logger::Id::testing> {
public:
using TestTimeSystemPtr = std::unique_ptr<Event::TestTimeSystem>;
using InstanceConstSharedPtrFn = std::function<Network::Address::InstanceConstSharedPtr(int)>;

// Creates a test fixture with an upstream bound to INADDR_ANY on an unspecified port using the
// provided IP |version|.
BaseIntegrationTest(Network::Address::IpVersion version,
const std::string& config = ConfigHelper::httpProxyConfig());
BaseIntegrationTest(Network::Address::IpVersion version, TestTimeSystemPtr,
const std::string& config = ConfigHelper::httpProxyConfig())
: BaseIntegrationTest(version, config) {}
// Creates a test fixture with a specified |upstream_address| function that provides the IP and
// port to use.
BaseIntegrationTest(const InstanceConstSharedPtrFn& upstream_address_fn,
Network::Address::IpVersion version,
const std::string& config = ConfigHelper::httpProxyConfig());
virtual ~BaseIntegrationTest() = default;

// TODO(jmarantz): Remove this once
// https://github.com/envoyproxy/envoy-filter-example/pull/69 is reverted.
static TestTimeSystemPtr realTime() { return TestTimeSystemPtr(); }

// Initialize the basic proto configuration, create fake upstreams, and start Envoy.
virtual void initialize();
// Set up the fake upstream connections. This is called by initialize() and
Expand Down
2 changes: 1 addition & 1 deletion test/integration/custom_cluster_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class CustomClusterIntegrationTest : public testing::TestWithParam<Network::Addr
public HttpIntegrationTest {
public:
CustomClusterIntegrationTest()
: HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam(), realTime()) {}
: HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam()) {}

void initialize() override {
setUpstreamCount(1);
Expand Down
7 changes: 0 additions & 7 deletions test/integration/http_integration.h
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,6 @@ using IntegrationCodecClientPtr = std::unique_ptr<IntegrationCodecClient>;
*/
class HttpIntegrationTest : public BaseIntegrationTest {
public:
// TODO(jmarantz): Remove this once
// https://github.com/envoyproxy/envoy-filter-example/pull/69 is reverted.
HttpIntegrationTest(Http::CodecClient::Type downstream_protocol,
Network::Address::IpVersion version, TestTimeSystemPtr,
const std::string& config = ConfigHelper::httpProxyConfig())
: HttpIntegrationTest(downstream_protocol, version, config) {}

HttpIntegrationTest(Http::CodecClient::Type downstream_protocol,
Network::Address::IpVersion version,
const std::string& config = ConfigHelper::httpProxyConfig());
Expand Down
3 changes: 1 addition & 2 deletions test/integration/listener_lds_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ class ListenerIntegrationTest : public HttpIntegrationTest,
absl::flat_hash_map<std::string, FakeStreamPtr> stream_by_resource_name_;
};

ListenerIntegrationTest()
: HttpIntegrationTest(Http::CodecClient::Type::HTTP1, ipVersion(), realTime()) {}
ListenerIntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, ipVersion()) {}

~ListenerIntegrationTest() override { resetConnections(); }

Expand Down
3 changes: 1 addition & 2 deletions test/integration/scoped_rds_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ class ScopedRdsIntegrationTest : public HttpIntegrationTest,
absl::flat_hash_map<std::string, FakeStreamPtr> stream_by_resource_name_;
};

ScopedRdsIntegrationTest()
: HttpIntegrationTest(Http::CodecClient::Type::HTTP1, ipVersion(), realTime()) {}
ScopedRdsIntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, ipVersion()) {}

~ScopedRdsIntegrationTest() override { resetConnections(); }

Expand Down
4 changes: 2 additions & 2 deletions test/integration/vhds_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ class VhdsInitializationTest : public HttpIntegrationTest,
public Grpc::GrpcClientIntegrationParamTest {
public:
VhdsInitializationTest()
: HttpIntegrationTest(Http::CodecClient::Type::HTTP2, ipVersion(), realTime(), config()) {
: HttpIntegrationTest(Http::CodecClient::Type::HTTP2, ipVersion(), config()) {
use_lds_ = false;
}

Expand Down Expand Up @@ -249,7 +249,7 @@ class VhdsIntegrationTest : public HttpIntegrationTest,
public Grpc::GrpcClientIntegrationParamTest {
public:
VhdsIntegrationTest()
: HttpIntegrationTest(Http::CodecClient::Type::HTTP2, ipVersion(), realTime(), config()) {
: HttpIntegrationTest(Http::CodecClient::Type::HTTP2, ipVersion(), config()) {
use_lds_ = false;
}

Expand Down