backport 1.17: wasm: fix getHeaderMapValue() in case of early client disconnect. (#1…#15395
Merged
Shikugawa merged 2 commits intoenvoyproxy:release/v1.17from Mar 15, 2021
Merged
Conversation
…voyproxy#15224) Previously, getHeaderMapValuei() would incorrectly return BadArgument when called in the access log phase after an early client disconnect, because the code assumed that a HeaderMap can point to a nullptr only when called from a callback in which given map is not available. Fixes proxy-wasm/proxy-wasm-rust-sdk#82. Signed-off-by: Piotr Sikora <piotrsikora@google.com> Signed-off-by: Shikugawa <rei@tetrate.io>
Shikugawa
changed the title
…nto backport-1.17/15224 Signed-off-by: Shikugawa <rei@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…5224)
Previously, getHeaderMapValuei() would incorrectly return BadArgument
when called in the access log phase after an early client disconnect,
because the code assumed that a HeaderMap can point to a nullptr only
when called from a callback in which given map is not available.
Fixes proxy-wasm/proxy-wasm-rust-sdk#82.
Signed-off-by: Piotr Sikora piotrsikora@google.com
Signed-off-by: Shikugawa rei@tetrate.io
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]