listener: move active_udp_listener out of conn handler#15349
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Mar 8, 2021
Merged
listener: move active_udp_listener out of conn handler#15349mattklein123 merged 2 commits intoenvoyproxy:mainfrom
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
lambdai
requested review from
alyssawilk,
ggreenway and
mattklein123
as code owners
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
ggreenway
approved these changes
Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Move active_udp_listener out of conn handler.
Signed-off-by: Yuchen Dai silentdai@gmail.com
Additional Description:
Also inline a legacy listener api v2 to v3 update.^^ v2 v3 API changes is reverted. I will create a separate PR
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]