Add separate SPIFFE integeration test build target.#15324
Merged
mattklein123 merged 3 commits intoenvoyproxy:mainfrom Mar 8, 2021
Merged
Add separate SPIFFE integeration test build target.#15324mattklein123 merged 3 commits intoenvoyproxy:mainfrom
mattklein123 merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Contributor
|
Thanks for the help with this. I'll take a look a bit later. Also, I think that test/extensions/transport_sockets/tls/cert_validator/factory_test.cc will fail if the SPIFFE cert verifier extension were disabled. |
Member
Author
I think It's not. It just uses the string literal "spiffe" and that's it. |
lizan
reviewed
Mar 5, 2021
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
antoniovicente
approved these changes
Mar 5, 2021
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for moving the spiffe test to the cert validator directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io
Commit Message: Add separate SPIFFE integeration test build target.
Additional Description: SPIFFE certificate validator is not a "core" extension, so this commit separates out its integration test from ssl_integration_test in order to remove the dependency of core integration tests on non-core SPIFFE cert validator extension.
resolves: #14884 (comment)
ref: #9953