rbac: support to configure the shadow rule stat with a custom prefix.#15323
Merged
mattklein123 merged 3 commits intoenvoyproxy:mainfrom Mar 6, 2021
Merged
rbac: support to configure the shadow rule stat with a custom prefix.#15323mattklein123 merged 3 commits intoenvoyproxy:mainfrom
mattklein123 merged 3 commits intoenvoyproxy:mainfrom
Conversation
This is useful when there are more than 1 RBAC filter configured with shadow rules to distinguish the shadow stats generated by different filters. Signed-off-by: Yangmin Zhu <ymzhu@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Yangmin Zhu <ymzhu@google.com>
mattklein123
requested changes
Mar 5, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks LGTM with small doc nit.
/wait
Signed-off-by: Yangmin Zhu <ymzhu@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yangmin Zhu ymzhu@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Add a new field
shadow_rules_stat_prefixto allow configuring a custom prefix to the stats generated by shadow rules.Additional Description: This is useful when there are more than 1 RBAC filter configured with shadow rules to distinguish the shadow stats generated by different filters.
Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: Added note for the change
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]