Skip to content

build: Add envoy_extension_py_test for excluding extensions with py_tests#15319

Merged
mattklein123 merged 5 commits intoenvoyproxy:mainfrom
markguan-stripe:main
Mar 8, 2021
Merged

build: Add envoy_extension_py_test for excluding extensions with py_tests#15319
mattklein123 merged 5 commits intoenvoyproxy:mainfrom
markguan-stripe:main

Conversation

@markguan-stripe
Copy link
Contributor

@markguan-stripe markguan-stripe commented Mar 4, 2021

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message: Add envoy_extension_py_test too allow for excluding extensions that have py_tests in builds
Additional Description:

Currently, we can't exclude the envoy.filters.network.kafka_broker extension from our build because the kafka_broker_integration_test py_test will fail. This prevents us from reducing our build size. Instead, we should add a wrapper around py_tests used in extensions, similar to envoy_extension_cc_test, so that the test won't be included as a target when extension_name is not in EXTENSIONS. This will be useful going forward if more extensions end up using py_tests.

Risk Level: Low
Testing: Manual testing on all tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

Hi @markguan-stripe, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #15319 was opened by markguan-stripe.

see: more, trace.

Signed-off-by: Mark Guan <markguan@stripe.com>
Signed-off-by: Mark Guan <markguan@stripe.com>
Signed-off-by: Mark Guan <markguan@stripe.com>
Signed-off-by: Mark Guan <markguan@stripe.com>
@murray-stripe
Copy link
Contributor

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #15319 (comment) was created by @murray-stripe.

see: more, trace.

@markguan-stripe
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #15319 (comment) was created by @markguan-stripe.

see: more, trace.

@mattklein123 mattklein123 merged commit f10ead4 into envoyproxy:main Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants