Skip to content

[fuzz] fix h1 end to end fuzz test issue #15318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asraa merged 4 commits into from
Mar 8, 2021
Merged

[fuzz] fix h1 end to end fuzz test issue #15318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df7633a
fix h1 filepath issue
asraa Mar 4, 2021
139deb7
fix bootrstrap path
asraa Mar 4, 2021
e0ce712
fix arm
asraa Mar 4, 2021
206442f
address comment
asraa Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/integration/h1_capture_direct_response_fuzz_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@ namespace Envoy {

void H1FuzzIntegrationTest::initialize() {
const std::string body = "Response body";
const std::string file_path = TestEnvironment::writeStringToFileForTest("test_envoy", body);
const std::string prefix("/");
const Http::Code status(Http::Code::OK);
config_helper_.addConfigModifier(
[&file_path, &prefix](
[&body, &prefix](
envoy::extensions::filters::network::http_connection_manager::v3::HttpConnectionManager&
hcm) -> void {
auto* route_config = hcm.mutable_route_config();
Expand All @@ -19,7 +18,9 @@ void H1FuzzIntegrationTest::initialize() {
hcm.mutable_route_config()->mutable_virtual_hosts(0)->mutable_routes(0);
default_route->mutable_match()->set_prefix(prefix);
default_route->mutable_direct_response()->set_status(static_cast<uint32_t>(status));
default_route->mutable_direct_response()->mutable_body()->set_filename(file_path);
// Use inline bytes rather than a filename to avoid using a path that may look illegal to
// Envoy.
default_route->mutable_direct_response()->mutable_body()->set_inline_bytes(body);
// adding headers to the default route
auto* header_value_option = route_config->mutable_response_headers_to_add()->Add();
header_value_option->mutable_header()->set_value("direct-response-enabled");
Expand Down
3 changes: 3 additions & 0 deletions ...tion/h1_corpus/clusterfuzz-testcase-h1_capture_direct_response_fuzz_test-5145199254831104
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions test/integration/h2_capture_direct_response_fuzz_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,14 @@ namespace Envoy {

void H2FuzzIntegrationTest::initialize() {
const std::string body = "Response body";
const std::string file_path = TestEnvironment::writeStringToFileForTest("test_envoy", body);
const std::string prefix("/");
const Http::Code status(Http::Code::OK);

setDownstreamProtocol(Http::CodecClient::Type::HTTP2);
setUpstreamProtocol(FakeHttpConnection::Type::HTTP2);

config_helper_.addConfigModifier(
[&file_path, &prefix](
[&body, &prefix](
envoy::extensions::filters::network::http_connection_manager::v3::HttpConnectionManager&
hcm) -> void {
auto* route_config = hcm.mutable_route_config();
Expand All @@ -23,7 +22,9 @@ void H2FuzzIntegrationTest::initialize() {
hcm.mutable_route_config()->mutable_virtual_hosts(0)->mutable_routes(0);
default_route->mutable_match()->set_prefix(prefix);
default_route->mutable_direct_response()->set_status(static_cast<uint32_t>(status));
default_route->mutable_direct_response()->mutable_body()->set_filename(file_path);
// Use inline bytes rather than a filename to avoid using a path that may look illegal to
// Envoy.
default_route->mutable_direct_response()->mutable_body()->set_inline_bytes(body);
// adding headers to the default route
auto* header_value_option = route_config->mutable_response_headers_to_add()->Add();
header_value_option->mutable_header()->set_value("direct-response-enabled");
Expand Down
28 changes: 28 additions & 0 deletions test/integration/h2_corpus/clusterfuzz-testcase-h2_capture_fuzz_test-5096668204761088
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.