Crash Dumper: E2E tests using kill filter#15314
Merged
htuch merged 5 commits intoenvoyproxy:mainfrom Mar 8, 2021
Merged
Conversation
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
htuch
reviewed
Mar 5, 2021
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM modulo nit. Thanks for improving testing!
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Contributor
Author
|
/retest Network flake |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
htuch
previously approved these changes
Mar 5, 2021
Member
|
@KBaichoo seems a legit CI failure, can you take a look? |
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Contributor
Author
|
Fixed -- the test doesn't make sense to run under the compile time options mode since it requires Envoy to handle signals which that mode disables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Baichoo kbaichoo@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: E2E test for crash dumper using the kill filter
Additional Description: The separate components where we have crash dumping support have individual unit tests, some with more mocks than others. E2E tests will build more confidence in the crash dumping pipeline.
Risk Level: Low (tests only)
Testing: Integration tests
Docs Changes: NA
Release Notes: NA
Platform Specific Features: Systems that use the crash handlers (windows doesn't currently)
Fixes #14249