json transcoder: set decoded percent-encoded message as json response#15276
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Mar 5, 2021
Merged
json transcoder: set decoded percent-encoded message as json response#15276mattklein123 merged 1 commit intoenvoyproxy:mainfrom
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Shikugawa <rei@tetrate.io>
qiwzhang
approved these changes
Mar 3, 2021
dmitri-d
reviewed
Mar 3, 2021
| {"content-type", "application/grpc"}, | ||
| {"grpc-status", "5"}, | ||
| {"grpc-message", "Resource%20not%20found"}}; | ||
| EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_.encodeHeaders(response_headers, true)); |
Contributor
There was a problem hiding this comment.
Do you think these checks are necessary here? We are only verifying that percent-encoded grpc status has been decoded; the other checks have been performed elsewhere and imo only muddle this test.
Member
Author
There was a problem hiding this comment.
I think that these redundant tests aren't necessarily bad.
lizan
approved these changes
Mar 5, 2021
mattklein123
approved these changes
Mar 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shikugawa rei@tetrate.io
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Close #15193. Fix not to set percent-encoded message as transcoded json response.
Additional Description:
Risk Level: Low
Testing: Unit
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]