upstream: avoid double hashing of protos in CDS init#15241
Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom Mar 2, 2021
Merged
upstream: avoid double hashing of protos in CDS init#15241alyssawilk merged 1 commit intoenvoyproxy:mainfrom
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@intel.com>
alyssawilk
reviewed
Mar 1, 2021
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
code LGTM but given all your improvements in this space what do you think about adding a benchmark (and/or commenting benchmark improvements in the perf PRs)?
Contributor
I'm planning to take over and complete PR #14167 for adding benchmarks. This is actually quite visible on internal CPU profiles at 7%. |
yanavlasov
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: upstream: avoid double hashing of protos in CDS init
Additional Description:
Currently Cluster messages are hashed unconditionally upon instantiation of
ClusterManagerImpl::ClusterDataeven if their hashes are known already.Calculate the hashes outside of
ClusterManagerImpl::ClusterDatactor to make use of already calculated ones.Risk Level: Low
Testing: unit tests, manual tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Contributes to #12138