backport 1.15: http: reinstating prior connect timeout behavior#15234
Merged
alyssawilk merged 2 commits intoenvoyproxy:release/v1.15from Mar 3, 2021
Merged
backport 1.15: http: reinstating prior connect timeout behavior#15234alyssawilk merged 2 commits intoenvoyproxy:release/v1.15from
alyssawilk merged 2 commits intoenvoyproxy:release/v1.15from
Conversation
Signed-off-by: alyssawilk <alyssar@chromium.org>
Signed-off-by: Shikugawa <rei@tetrate.io>
Shikugawa
force-pushed
the
backport-1.15/14685
branch
from
bf50f15 to
4dc26c9
Compare
alyssawilk
approved these changes
Mar 1, 2021
Contributor
|
please clone release notes from the original PR and ping when you're ready for merge! |
Member
Author
|
@alyssawilk ready to merge |
Contributor
|
Done! thanks for all your backporting work this quarter! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: alyssawilk alyssar@chromium.org
#10854 inadvertently changed the behavior of connect timeouts. This reinstates prior behavior.
Risk Level: Low (reinstating prior behavior)
Testing: added regression test
Docs Changes: n/a
Release Notes: inline
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]