jwt_authn: fix a bug where JWT with wrong issuer is allowed in allow_missing case#15194
Merged
asraa merged 3 commits intoenvoyproxy:mainfrom Feb 26, 2021
Merged
Conversation
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
Contributor
Author
|
@yangminzhu could you help to review it? |
Member
|
@lizan tagging for a pass from you, thanks! |
lizan
previously approved these changes
Feb 25, 2021
yangminzhu
reviewed
Feb 25, 2021
yangminzhu
previously approved these changes
Feb 25, 2021
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
yangminzhu
approved these changes
Feb 25, 2021
Contributor
yangminzhu
left a comment
yangminzhu
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
asraa
approved these changes
Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
allow_missingis used insideRequiresAny, the requests with JWT with wrong issuer are accepted. This is a bug,allow_missingshould only allow requests without any JWT.This change fixed the above issue by preserving JwtUnknownIssuer in
allow_missingcase.Change details:
Risk Level: Low
Testing: unit-tested
Docs Changes: N/A
Release Notes: Yes