brotoli: fix CI by adding category field to bazel BUILD files#14987
Merged
lizan merged 1 commit intoenvoyproxy:mainfrom Feb 9, 2021
Merged
brotoli: fix CI by adding category field to bazel BUILD files#14987lizan merged 1 commit intoenvoyproxy:mainfrom
lizan merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: John Esmet <john.esmet@gmail.com>
Member
|
@lizan @yanavlasov PTAL this currently blocks the CI |
antoniovicente
approved these changes
Feb 8, 2021
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Seems correct, waiting for CI before I can merge.
cc @envoyproxy/senior-maintainers or @envoyproxy/admins who AFAIK can force submit without waiting for CI
Member
|
lgtm |
Contributor
|
Thanks - fixes issue reported #12998 (comment) |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lizan
approved these changes
Feb 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: brotoli: fix CI by adding category field to bazel BUILD files
Additional Description:
Risk Level: low
Testing: ci/run_envoy_docker.sh 'ci/do_ci.sh deps'
Docs Changes: none
Release Notes: none