Skip to content

docs: Add admin section back to quick-start demo (Fix #14811)#14833

Merged
yanavlasov merged 1 commit intoenvoyproxy:mainfrom
sandipb:main
Jan 28, 2021
Merged

docs: Add admin section back to quick-start demo (Fix #14811)#14833
yanavlasov merged 1 commit intoenvoyproxy:mainfrom
sandipb:main

Conversation

@sandipb
Copy link
Contributor

@sandipb sandipb commented Jan 27, 2021

Makes the config file consistent with the documentation.

Fixes #14811

Signed-off-by: Sandip Bhattacharya sandipb@showmethesource.org

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Makes the config file consistent with the documentation.

Signed-off-by: Sandip Bhattacharya <sandipb@showmethesource.org>
@repokitteh-read-only
Copy link

Hi @sandipb, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #14833 was opened by sandipb.

see: more, trace.

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @sandipb

@phlax
Copy link
Member

phlax commented Jan 27, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14833 (comment) was created by @phlax.

see: more, trace.

@phlax
Copy link
Member

phlax commented Jan 27, 2021

@sandipb if you add "Fix #14811" to the description it should auto close your bug when it is merged

@sandipb sandipb changed the title docs: Add admin section back to quick-start demo (#14811) docs: Add admin section back to quick-start demo (Fix #14811) Jan 27, 2021
@sandipb
Copy link
Contributor Author

sandipb commented Jan 27, 2021

@sandipb if you add "Fix #14811" to the description it should auto close your bug when it is merged

I was not sure which description you meant :) I updated the pull request description. Or do you think the git commit itself should have it in the description?

@phlax
Copy link
Member

phlax commented Jan 27, 2021

either should work - the pr is probs best so it is obvious to reviewers

@phlax
Copy link
Member

phlax commented Jan 27, 2021

see this section in description:

[Optional Fixes #Issue]

@sandipb
Copy link
Contributor Author

sandipb commented Jan 27, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #14833 (comment) was created by @sandipb.

see: more, trace.

@yanavlasov yanavlasov merged commit 2ee9543 into envoyproxy:main Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quick start demo file doesn't enable admin

3 participants