router: support downstream cert formatting in the header formatter#14830
router: support downstream cert formatting in the header formatter#14830zuercher merged 6 commits intoenvoyproxy:mainfrom
Conversation
esmet
force-pushed
the
downstream-cert-formatter-header
branch
from
c869bc8 to
2a4f0d9
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/retest |
|
Retrying Azure Pipelines: |
dio
left a comment
dio
left a comment
There was a problem hiding this comment.
While still thinking about unifying this in the access log site or here, a nit and a question:
Signed-off-by: John Esmet <john.esmet@gmail.com>
Signed-off-by: John Esmet <john.esmet@gmail.com>
Signed-off-by: John Esmet <john.esmet@gmail.com>
|
I have to force push to fix a DCO issue with 1 of the commits in this PR. I'm not totally sure how I messed it up, but I'll fix it now! |
Actually I see why this was messed up. It's because I made a change using the GitHub UI to update current.rst. I will know not to do that in the future. |
esmet
force-pushed
the
downstream-cert-formatter-header
branch
from
6e765fd to
08f854f
Compare
|
/retest |
|
Retrying Azure Pipelines: |
…tter-header Signed-off-by: John Esmet <john.esmet@gmail.com>
Signed-off-by: John Esmet <john.esmet@gmail.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@zuercher do you want to take a look? |
|
@zuercher friendly poke. If you think this is okay, then it should be ready to land 👍 |
|
Sorry for being slow. |
…nvoyproxy#14830) This extends downstream cert formatting capabilities to the router's header formatter. Risk Level: Low Testing: Unit tests Docs Changes: Updated custom request/response header docs Release Notes: added Fixes envoyproxy#14501
…nvoyproxy#14830) This extends downstream cert formatting capabilities to the router's header formatter. Risk Level: Low Testing: Unit tests Docs Changes: Updated custom request/response header docs Release Notes: added Fixes envoyproxy#14501
…nvoyproxy#14830) This extends downstream cert formatting capabilities to the router's header formatter. Risk Level: Low Testing: Unit tests Docs Changes: Updated custom request/response header docs Release Notes: added Fixes envoyproxy#14501
4 participants
This extends downstream cert formatting capabilities to the router's header formatter. The previous related PR only added support to the access log formatter.
The first commit implements the feature in very direct way. The second commit refactors it to reuse some existing code. I left both commits separate so that reviewer(s) can look at each implementation and decide which is better.
Commit Message: router: support downstream cert formatting in the header formatter
Additional Description:
Risk Level: Low
Testing: Unit tests
Docs Changes: Updated custom request/response header docs
Release Notes: router: extend custom date formatting to DOWNSTREAM_PEER_CERT_V_START and DOWNSTREAM_PEER_CERT_V_END when using :ref:
custom request/response header formats <config_http_conn_man_headers_custom_request_headers>.Fixes #14501