http: error handling for bad factory type#14769
Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom Jan 25, 2021
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
snowp
approved these changes
Jan 21, 2021
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Thanks, this seems reasonable to me as a short term solution until we can make the API changes
aunu53
pushed a commit
to aunu53/envoy
that referenced
this pull request
Jan 25, 2021
Probably we should eventually split upstream config into explicit tcp_upstream_config and http_upstream_config so we can validate on ingress. This is at least a step in the right direction. Commit Message: avoiding a crash on bad http upstream config, mirroring what we do for the tcp path. Risk Level: Low Testing: new unit test Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Auni Ahsan <auni@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably we should eventually split upstream config into explicit tcp_upstream_config and http_upstream_config so we can validate on ingress. This is at least a step in the right direction.
Commit Message: avoiding a crash on bad http upstream config, mirroring what we do for the tcp path.
Risk Level: Low
Testing: new unit test
Docs Changes: n/a
Release Notes: n/a