Skip to content

[ci] test azp coverage artifact logging #14691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizan merged 7 commits into from
Jan 29, 2021
Merged

[ci] test azp coverage artifact logging #14691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f725cb
test coverage log
asraa Jan 13, 2021
91fda1d
fix build
asraa Jan 14, 2021
3b9d8fa
fix var
asraa Jan 14, 2021
057e387
add env var
asraa Jan 14, 2021
6960c7e
add output var
asraa Jan 15, 2021
3d2b843
revert manual test removal
asraa Jan 15, 2021
dc47919
fix style
asraa Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ci/run_envoy_docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ docker run --rm \
-e GCP_SERVICE_ACCOUNT_KEY \
-e NUM_CPUS \
-e ENVOY_RBE \
-e FUZZIT_API_KEY \
-e ENVOY_BUILD_IMAGE \
-e ENVOY_SRCDIR \
-e ENVOY_BUILD_TARGET \
Expand Down
4 changes: 4 additions & 0 deletions ci/upload_gcs_artifact.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,8 @@ if [[ "$BUILD_REASON" == "PullRequest" ]]; then
gsutil -h "Cache-Control:no-cache,max-age=0" -mq rsync -dr "${TMP_REDIRECT}" "gs://${GCS_REDIRECT}"
fi

if [[ "${COVERAGE_FAILED}" -eq 1 ]]; then
echo "##vso[task.logissue type=error]Coverage failed, check artifact at: https://storage.googleapis.com/${GCS_LOCATION}/index.html"
fi

echo "Artifacts uploaded to: https://storage.googleapis.com/${GCS_LOCATION}/index.html"
3 changes: 3 additions & 0 deletions test/run_envoy_bazel_coverage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ if [[ "$VALIDATE_COVERAGE" == "true" ]]; then
fi
COVERAGE_FAILED=$(echo "${COVERAGE_VALUE}<${COVERAGE_THRESHOLD}" | bc)
if [[ "${COVERAGE_FAILED}" -eq 1 ]]; then
echo "##vso[task.setvariable variable=COVERAGE_FAILED]${COVERAGE_FAILED}"
echo "Code coverage ${COVERAGE_VALUE} is lower than limit of ${COVERAGE_THRESHOLD}"
exit 1
else
Expand All @@ -109,6 +110,8 @@ if [[ "$VALIDATE_COVERAGE" == "true" ]] && [[ "${FUZZ_COVERAGE}" == "false" ]];
if [ $? -eq 1 ]; then
echo Per-extension coverage failed:
echo "$output"
COVERAGE_FAILED=1
echo "##vso[task.setvariable variable=COVERAGE_FAILED]${COVERAGE_FAILED}"
exit 1
fi
echo Per-extension coverage passed.
Expand Down