Step 6: Add clang cl pipeline for Windows#14668
Merged
htuch merged 20 commits intoenvoyproxy:mainfrom Jan 29, 2021
Merged
Conversation
wrowe
force-pushed
the
add-clang-cl-pipeline
branch
from
ed15c9a to
2d9a357
Compare
sunjayBhatia
suggested changes
Jan 13, 2021
Member
sunjayBhatia
left a comment
sunjayBhatia
left a comment
There was a problem hiding this comment.
Could you add the repository cache task that was recently merged to the clang-cl pipeline: https://github.com/envoyproxy/envoy/pull/14678/files#diff-8ca122481a2ae193003b523bf5b7a9cfa0e914be502d483b6adc1d06668c724a
This should help with download flakiness on Windows
wrowe
commented
Jan 14, 2021
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com> Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
- Drop the distinction between flaky_ and fails_, now that flakes have been addressed, and very few true problems remain. Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
- This may require new logic in bazel itself for msvc version detection Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Author: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
- retest sni_dynamic_forward_proxy for error output Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
wrowe
force-pushed
the
add-clang-cl-pipeline
branch
from
3889195 to
59f1059
Compare
wrowe
commented
Jan 14, 2021
- msvc-cl 'release' and 'clang-cl' jobs in parallel - share repository cache since they share identical dependencies Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
wrowe
requested review from
alyssawilk,
ggreenway and
mattklein123
as code owners
Contributor
Author
|
@lizan , @sunjayBhatia this looks ready for final review. |
Member
sunjayBhatia
left a comment
sunjayBhatia
left a comment
There was a problem hiding this comment.
Just a couple questions, otherwise LGTM
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
- suggested by sunjayBhatia as Windows docker images are rather large and can take significant time to compose. Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
- This was put place with a gross of test failures, we are down to a handful of test failures and a dozen and a half deliberately skipped tests on the windows architecture - Leave an example of how to list all tests with a given tag Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Contributor
Author
|
Once again, @sunjayBhatia and @lizan, I think all the concerns have been asked and answered, but let me know if I can add any more polish to this submission before it's merged. We will be iterating over .pdb output (just as on msvc-cl) and the build output (right now, a 33% larger binary than the equivalent MS tooling, speed delta TBD.) |
sunjayBhatia
approved these changes
Jan 26, 2021
Contributor
Author
|
@htuch as this is your ask, and it's been reviewed and lizan's comments addressed, if you would like to move ahead please go ahead and merge this. |
Member
|
Amazing, thank you! |
htuch
approved these changes
Jan 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Step 6: Add clang cl pipeline for Windows
Additional Description:
Now that we have regenerated envoy build tools to update bazel and llvm, and picked up the llvm 11 tooling for windows on envoyproxy/master, finally introduce a clang-cl pipeline based on clang-cl
Co-authored-by: Sunjay Bhatia sunjayb@vmware.com
Risk Level: low (new facility)
Testing: local
Docs Changes: TBD
Release Notes: TBD
Platform Specific Features: Windows clang-cl compilation
Replaces #14135
Fixes #11974