Skip to content

filter manager: drop assert #14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 2 commits into from
Jan 11, 2021
Merged

filter manager: drop assert #14633

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14f0ae7
filter manager: drop assert
Jan 11, 2021
85bb143
Add TODO comment
Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion source/common/http/filter_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,10 @@ class OverridableRemoteSocketAddressSetterStreamInfo : public StreamInfo::Stream

void setDownstreamRemoteAddress(
const Network::Address::InstanceConstSharedPtr& downstream_remote_address) {
ASSERT(overridden_downstream_remote_address_ == nullptr);
// TODO(rgs1): we should assert overridden_downstream_remote_address_ is nullptr,
// but we are currently relaxing this as a workaround to:
//
// https://github.com/envoyproxy/envoy/pull/14432#issuecomment-758167614
overridden_downstream_remote_address_ = downstream_remote_address;
}

Expand Down