[kill request] Add API validation to avoid config crash#14398
Merged
asraa merged 4 commits intoenvoyproxy:mainfrom Jan 25, 2021
Merged
[kill request] Add API validation to avoid config crash#14398asraa merged 4 commits intoenvoyproxy:mainfrom
asraa merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
lizan
reviewed
Dec 14, 2020
| // A map of string keys to requirements. The string key is the string value | ||
| // in the FilterState with the name specified in the *name* field above. | ||
| map<string, JwtRequirement> requires = 3; | ||
| map<string, JwtRequirement> |
Contributor
Author
There was a problem hiding this comment.
Huh, that is strange. I think this happened while running proto format, I'll revert the JWT files.
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
lizan
approved these changes
Jan 22, 2021
Member
|
@asraa can you check CI? |
Signed-off-by: Asra Ali <asraa@google.com>
aunu53
pushed a commit
to aunu53/envoy
that referenced
this pull request
Jan 25, 2021
…4398) * fix kill request API validation for header Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: Auni Ahsan <auni@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Commit Message: Adds an API validation to kill request proto to a
LowerCaseStringfield.Testing: Add regression test