Skip to content

wasm: clear route cache when modifying HTTP request headers. #14318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizan merged 4 commits into from
Dec 15, 2020
Merged

wasm: clear route cache when modifying HTTP request headers. #14318

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18e9b3d
wasm: clear route cache when modifying HTTP request headers.
PiotrSikora Dec 8, 2020
cbc0b15
review: add tests.
PiotrSikora Dec 11, 2020
8af3aa6
Merge remote-tracking branch 'origin/master' into PiotrSikora/wasm-cl…
PiotrSikora Dec 11, 2020
c8b00f3
Merge remote-tracking branch 'origin/master' into PiotrSikora/wasm-cl…
PiotrSikora Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions source/extensions/common/wasm/context.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,9 @@ WasmResult Context::addHeaderMapValue(WasmHeaderMapType type, absl::string_view
}
const Http::LowerCaseString lower_key{std::string(key)};
map->addCopy(lower_key, std::string(value));
if (type == WasmHeaderMapType::RequestHeaders) {
decoder_callbacks_->clearRouteCache();
}
return WasmResult::Ok;
}

Expand Down Expand Up @@ -769,6 +772,9 @@ WasmResult Context::setHeaderMapPairs(WasmHeaderMapType type, const Pairs& pairs
const Http::LowerCaseString lower_key{std::string(p.first)};
map->addCopy(lower_key, std::string(p.second));
}
if (type == WasmHeaderMapType::RequestHeaders) {
decoder_callbacks_->clearRouteCache();
}
return WasmResult::Ok;
}

Expand All @@ -779,6 +785,9 @@ WasmResult Context::removeHeaderMapValue(WasmHeaderMapType type, absl::string_vi
}
const Http::LowerCaseString lower_key{std::string(key)};
map->remove(lower_key);
if (type == WasmHeaderMapType::RequestHeaders) {
decoder_callbacks_->clearRouteCache();
}
return WasmResult::Ok;
}

Expand All @@ -790,6 +799,9 @@ WasmResult Context::replaceHeaderMapValue(WasmHeaderMapType type, absl::string_v
}
const Http::LowerCaseString lower_key{std::string(key)};
map->setCopy(lower_key, value);
if (type == WasmHeaderMapType::RequestHeaders) {
decoder_callbacks_->clearRouteCache();
}
return WasmResult::Ok;
}

Expand Down