Skip to content

wasm: update V8 to v8.8.278.8.#14298

Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
PiotrSikora:v8_v8.8
Dec 9, 2020
Merged

wasm: update V8 to v8.8.278.8.#14298
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
PiotrSikora:v8_v8.8

Conversation

@PiotrSikora
Copy link
Contributor

Signed-off-by: Piotr Sikora piotrsikora@google.com

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #14298 was opened by PiotrSikora.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Dec 7, 2020
@mathetake
Copy link
Member

//test/extensions/filters/http/wasm:wasm_filter_test FAILED TO BUILD

FAILED TO BUILD? 😕

@PiotrSikora
Copy link
Contributor Author

//test/extensions/filters/http/wasm:wasm_filter_test FAILED TO BUILD

FAILED TO BUILD? 😕

Looks like there is a data race in std::shared_ptr that's caught by TSan during V8 build.

Not sure how that passed upstream. Might be also an older issue that's fixed in LLVM 11, since V8 is bundled with LLVM HEAD.

@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Dec 7, 2020
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit d3315cb into envoyproxy:master Dec 9, 2020
mpuncel added a commit to mpuncel/envoy that referenced this pull request Dec 11, 2020
* master:
  buffer: Optimize the layout of Slices in Buffer::OwnedImpl by removing subclassing and storing slice info directly in the SliceDeque (envoyproxy#14282)
  gRPC client to be used by ext_proc filter (envoyproxy#14283)
  http2: Add integration tests for PRIORITY frame flood mitigation for upstream servers (envoyproxy#14328)
  event: touch watchdog before execution of each post callback and before deferred deletion (envoyproxy#14339)
  stale: more allowed ops (envoyproxy#14345)
  stale: more changes (envoyproxy#14344)
  test: TODO fixup making enable_half_close private envoyproxy#14330)
  event: Reduce potential for lock contention while executing dispatcher post callbacks. (envoyproxy#14289)
  stale: fix config (envoyproxy#14337)
  metrics service sink: generalize the sink and grpc streamer for external use (envoyproxy#13919)
  wasm: update V8 to v8.8.278.8. (envoyproxy#14298)
  repo: switch to actions based stale bot (envoyproxy#14335)
  buffer: Use WatermarkFactory to create most WatermarkBuffer instances (envoyproxy#14256)

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants