Revert "ext_auth: add option to measure timeout when check request is created. (#12778)"#14152
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom Nov 24, 2020
Merged
Conversation
… created. (envoyproxy#12778)" This reverts commit dfa85e8. Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Contributor
Author
|
/retest I think a CI issue, as it failed building |
|
Retrying Azure Pipelines: |
Member
|
Looks like legit CI issue. /wait |
Contributor
Author
|
weird, as it builds fine locally. will try re-building with the exact clang version. |
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Contributor
Author
|
ok, merging latest master reproduced the failure; fixing |
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
mattklein123
previously approved these changes
Nov 23, 2020
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
|
|
||
| #include "test/common/stats/stat_test_utility.h" | ||
| #include "test/mocks/config/mocks.h" | ||
| #include "test/mocks/event/mocks.h" |
Member
There was a problem hiding this comment.
Why is this needed in the revert? Seems unrelated?
Contributor
Author
There was a problem hiding this comment.
In my code I added it to mocks/grpc/mocks.h,so it was included transitivly.. after the revert it is no longer in grpc/mocks.h
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Revert "ext_auth: add option to measure timeout when check request is created. (#12778)"