format: only check sh format for repository files#14146
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Nov 23, 2020
Merged
format: only check sh format for repository files#14146mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Right now, the shellcheck format checks all files under the directory, which is unfriendly for a number of reasons (git worktrees, dev scripts, autogenerated code). Instead of using find, use `git ls-files` to list files which can then be filtered. Signed-off-by: Alex Konradi <akonradi@google.com>
mattklein123
approved these changes
Nov 23, 2020
qqustc
pushed a commit
to qqustc/envoy
that referenced
this pull request
Nov 24, 2020
Right now, the shellcheck format checks all files under the directory, which is unfriendly for a number of reasons (git worktrees, dev scripts, autogenerated code). Instead of using find, use `git ls-files` to list files which can then be filtered. Signed-off-by: Alex Konradi <akonradi@google.com> Signed-off-by: Qin Qin <qqin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Only run shellcheck on repository files
Additional Description:
Right now, the shellcheck format checks all files under the directory,
which is unfriendly for a number of reasons (git worktrees, dev scripts,
autogenerated code). Instead of using find, use
git ls-filesto listfiles which can then be filtered.
Risk Level: low
Testing: ran CI fix_format
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a