test: reset coverage expectations for source/common/event/...#14140
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Nov 23, 2020
Merged
test: reset coverage expectations for source/common/event/...#14140mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
approved these changes
Nov 23, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Agreed this is a flake so let's go with this.
qqustc
pushed a commit
to qqustc/envoy
that referenced
this pull request
Nov 24, 2020
…14140) Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Qin Qin <qqin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: I suspect there's a flakiness in either the coverage system or in the tests for source/common/event/... This should probably be looked at somehow but this shouldn't become a flakiness issue for everyone running coverage tests in every PR.
Additional Description:
Risk Level: low
Testing: none
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a