-
Notifications
You must be signed in to change notification settings - Fork 5.3k
backport to 1.16: udp: properly handle truncated/dropped datagrams #14124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
be5bd08
6f741aa
8b7e76c
5c1f54c
edb20ea
d11a642
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.16.1-dev | ||
| 1.16.1 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,13 +8,13 @@ static_resources: | |
| - filters: | ||
| - name: envoy.filters.network.http_connection_manager | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager | ||
| "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be better if this change is a separate PR but not a crisis.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK. Created #14125, which to be merged to release/v1.16 first and I will create a new PR for UDP fix.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Created yet another PR #14127 for @antoniovicente fix to auth coverage test. I am going to close this PR, wait until the other two are merged to release/v1.16 and create a new PR just for UDP fixes. |
||
| codec_type: auto | ||
| stat_prefix: ingress_http | ||
| access_log: | ||
| - name: envoy.access_loggers.file | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.config.accesslog.v2.FileAccessLog | ||
| "@type": type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog | ||
| path: /dev/stdout | ||
| route_config: | ||
| name: local_route | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note all of these need to get merged to main at some point, so please make a note on that.