Skip to content

tracer: fix zipkin proto documentation #14112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 3 commits into from
Nov 23, 2020
Merged

tracer: fix zipkin proto documentation #14112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f18fbd3
fix zipkin docs
ramaraochavali Nov 20, 2020
b106aa2
kick ci
ramaraochavali Nov 21, 2020
38ff639
Merge remote-tracking branch 'upstream/master' into fix/zipkin_docs
ramaraochavali Nov 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions api/envoy/config/trace/v3/zipkin.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ message ZipkinConfig {
GRPC = 3;
}

// The cluster manager cluster that hosts the Zipkin collectors. Note that the
// Zipkin cluster must be defined in the :ref:`Bootstrap static cluster
// resources <envoy_api_field_config.bootstrap.v3.Bootstrap.StaticResources.clusters>`.
// The cluster manager cluster that hosts the Zipkin collectors.
string collector_cluster = 1 [(validate.rules).string = {min_len: 1}];

// The API endpoint of the Zipkin service where the spans will be sent. When
Expand Down
4 changes: 1 addition & 3 deletions api/envoy/extensions/tracers/zipkin/v4alpha/zipkin.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions generated_api_shadow/envoy/config/trace/v3/zipkin.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions generated_api_shadow/envoy/extensions/tracers/zipkin/v4alpha/zipkin.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.