Skip to content

backport to 1.16: test: avoid use after free in oauth_integration_test (#14103) #14109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
antoniovicente wants to merge 1 commit into from
Closed

backport to 1.16: test: avoid use after free in oauth_integration_test (#14103) #14109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/extensions/filters/http/oauth2/oauth_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ TEST_F(OauthIntegrationTest, UnauthenticatedFlow) {
{":authority", "authority"}};
auto encoder_decoder = codec_client_->startRequest(headers);

Buffer::OwnedImpl buffer;
encoder_decoder.first.encodeData(buffer, true);
request_encoder_ = &encoder_decoder.first;
auto response = std::move(encoder_decoder.second);

Expand Down Expand Up @@ -144,4 +142,4 @@ TEST_F(OauthIntegrationTest, AuthenticationFlow) {
} // namespace Oauth
} // namespace HttpFilters
} // namespace Extensions
} // namespace Envoy
} // namespace Envoy