[test] Add emptydata/continuation to upstream flood tests#14100
Merged
asraa merged 6 commits intoenvoyproxy:masterfrom Nov 24, 2020
Merged
[test] Add emptydata/continuation to upstream flood tests#14100asraa merged 6 commits intoenvoyproxy:masterfrom
asraa merged 6 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
alyssawilk
approved these changes
Nov 23, 2020
Contributor
|
I assume the coverage failure is a flake? I'll kick off a new run and you can merge if it passes. |
Contributor
Author
|
Thanks! I may need to merge main, it looks like it failed (and some other PRs did) on low source/common/network coverage. The post submit coverage report is fine, though. Will keep an eye. |
Signed-off-by: Asra Ali <asraa@google.com>
qqustc
pushed a commit
to qqustc/envoy
that referenced
this pull request
Nov 24, 2020
…#14100) * add upstream flood tests to detect empty data and empty continuation frames Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: Qin Qin <qqin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Added EmptyData and EmptyContinuation frame to upstream flood tests.
EmptyData test shows headers will still be received if started, both tests use the default limit of 1 empty consecutive frame.
Risk Level: Low (tests)
Testing: Tests added.
Fixes part of #12281
Signed-off-by: Asra Ali asraa@google.com